Diagnostic API and service for Inputs #20958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonEbel
requested changes
Nov 18, 2024
| if (errors != null && !errors.isEmpty()) { | ||
| LOG.error("An error occurred while executing aggregation: {}", | ||
| errors.stream().map(SearchError::description).collect(Collectors.joining(", "))); | ||
| return EMPTY_DIAGNOSTICS; |
There was a problem hiding this comment.
It may be better to pass the error message to the UI here, otherwise it would be a bit confusing for the user
| private static AbstractMap.SimpleEntry<String, Long> extractValues(PivotResult.Row r) { | ||
| if (r.values().size() != 1) { | ||
| LOG.warn("Expected 1 value in aggregation result, but received [{}].", r.values().size()); | ||
| return null; |
There was a problem hiding this comment.
Here, too, it might make more sense to throw an exception instead of displaying incomplete data.
| final String streamId = r.key().get(0); | ||
| if (StringUtils.isEmpty(streamId)) { | ||
| LOG.warn("Expected a stream ID to be returned."); | ||
| return null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/nocl new feature
Relates to issue #20683
A new API and service to provide data for the Input Setup Wizard.
The new endpoint:
GET system/inputs/diagnostics/{inputId}Returns a JSON data structure, currently only with a single object representing the message count by stream. We may add to this in future. E.g.:
In case of no data we return an empty map: