Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reusability of widget edit components #20843

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improve reusability of widget edit components #20843

wants to merge 7 commits into from

Commits on Nov 26, 2024

  1. Remove redux store usage from EditWidgetFrame.

    @linuspahl
    linuspahl committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c5dad21 View commit details
    Browse the repository at this point in the history

  2. Simplify WidgetEditApplyAllChangesProvider.

    @linuspahl
    linuspahl committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b16e930 View commit details
    Browse the repository at this point in the history

  3. Improve reusability of field select component.

    @linuspahl
    linuspahl committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8a642cb View commit details
    Browse the repository at this point in the history

  4. Decouple EditWidgetFrame from redux state.

    @linuspahl
    linuspahl committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    542fd0e View commit details
    Browse the repository at this point in the history

  5. Simplify widget edit submit logic by removing onSubmit prop from wi… 

    …dget edit components. Instead we only call `applyAllWidgetChanges` from `WidgetEditApplyAllChangesContext.

The `WidgetEditApplyAllChangesProvider` now calls a `onSubmit` prop which takes care of updateing the widget.
    @linuspahl
    linuspahl committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    29be003 View commit details
    Browse the repository at this point in the history

  6. Add note for UPGRADING doc.

    @linuspahl
    linuspahl committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    51bee8e View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Allows readonly widget title.

    @linuspahl
    linuspahl committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1fbde01 View commit details
    Browse the repository at this point in the history