Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the OpenSearch Client in general and the Server in the DataNode to 2.15 #20097

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Aug 6, 2024

Description

Bumping our OpenSearch usage to 2.15:

  • client used to connect to OpenSearch (does in general not restrict the server version used)
  • server inside the DataNode

Background is: the core team works on a feature that needs the fix in opensearch-project/OpenSearch#12812 which is only available in the client from 2.15 on.

And in general, we tested 2.15 a bit more than other versions because 2.14 had some bugs so I think it's a good step to bump the versions from 2.12 to 2.15 so that it's clear that everyone should stay away from that buggy version.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise marked this pull request as ready for review August 6, 2024 17:25
@janheise janheise changed the title Bumping the OpenSearch Client and the Server in the DataNode to 2.15 Bumping the OpenSearch Client in general and the Server in the DataNode to 2.15 Aug 7, 2024
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are working, I don't see any problem with this.

@janheise janheise merged commit 356d252 into master Aug 7, 2024
17 of 19 checks passed
@janheise janheise deleted the bump-os-to-215 branch August 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants