Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized install info related to fwupd bug on Debian-based distros #1091

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rslurry
Copy link

@rslurry rslurry commented Dec 30, 2024

Updated Web Install info related to issue #1088 about the fwupd bug in Debian and some Ubuntu versions. This avoids unnecessarily stopping fwupd on releases that don't have the bug, and it keeps the guide generalized for applicability to other Debian- and Ubuntu-derived distros. It won't need to be revisited until years from now when Debian and Ubuntu entirely drop support for the current releases that use the outdated fwupd version.

Copy link
Member

@thestinger thestinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be kept in sync between the CLI and web install guides.

@@ -54,7 +54,7 @@ <h2><a href="#table-of-contents">Table of contents</a></h2>
<li><a href="#prerequisites">Prerequisites</a></li>
<li><a href="#enabling-oem-unlocking">Enabling OEM unlocking</a></li>
<li><a href="#flashing-as-non-root">Flashing as non-root</a></li>
<li><a href="#working-around-fwupd-bug-on-linux-distributions">Working around fwupd bug on Linux distributions</a></li>
<li><a href="#working-around--bug-on-linux-distributions">Working around bug on Linux distributions</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks accidental.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't intentionally touch anything there - must have been an accident when Ctrl+F'ing for fwupd. Thanks for catching that.

@rslurry
Copy link
Author

rslurry commented Dec 30, 2024

Alright, that accidental deletion was fixed, and the CLI guide was updated to match.

@rslurry rslurry requested a review from thestinger December 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants