Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in docs #928

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Update links in docs #928

merged 3 commits into from
Sep 13, 2024

Conversation

oleg-nenashev
Copy link
Contributor

@oleg-nenashev oleg-nenashev commented Jul 28, 2024

For #908

@Goooler
Copy link
Member

Goooler commented Jul 28, 2024

More links have to be updated?

image

@oleg-nenashev
Copy link
Contributor Author

@Goooler Agreed. I patched the link for the GradleUp site, but I will update the rest too.
Javadoc links work well as of now: https://gradleup.com/shadow/api/

@Marcono1234
Copy link
Contributor

Should there be a note on the README (and maybe the User Guide) that this repository previously had a different owner (and maybe link to #908)?
Users might have become familiar with johnrengelman/shadow and https://imperceptiblethoughts.com/shadow/ and might be slightly confused about the different organization now.

@Goooler
Copy link
Member

Goooler commented Jul 30, 2024

That sounds good!

@Goooler
Copy link
Member

Goooler commented Aug 8, 2024

This can move on, we land it.

https://github.com/GradleUp/shadow/releases/tag/8.3.0

@oleg-nenashev oleg-nenashev self-assigned this Aug 8, 2024
@oleg-nenashev
Copy link
Contributor Author

Yup, will get it over the line

@Goooler
Copy link
Member

Goooler commented Sep 13, 2024

@oleg-nenashev Are you ready to merge this one?

@oleg-nenashev
Copy link
Contributor Author

I think so

@oleg-nenashev
Copy link
Contributor Author

Not sure what your policy is for squash managers, but content wise it looks good. Thanks for actually doing most of the work

@Goooler Goooler changed the title Update the User Guide link in README.md Update links in docs Sep 13, 2024
@Goooler Goooler merged commit fb6fd06 into main Sep 13, 2024
9 checks passed
@Goooler Goooler deleted the oleg-nenashev-patch-1 branch September 13, 2024 08:27
@Goooler
Copy link
Member

Goooler commented Sep 13, 2024

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants