more consistent facade for merge

GowenGit · May 28, 2021 · b4bf895 · b4bf895
1 parent fb44efe
commit b4bf895
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/src/Docnet.Core/DocLib.cs b/src/Docnet.Core/DocLib.cs
@@ -97,7 +97,7 @@ public byte[] Merge(byte[] fileOne, byte[] fileTwo)
         }
 
         /// <inheritdoc />
-        public byte[] Merge(IList<byte[]> files)
+        public byte[] Merge(IReadOnlyList<byte[]> files)
         {
             Validator.CheckCollectionNotEmpty(files, nameof(files));
 

diff --git a/src/Docnet.Core/Editors/DocEditor.cs b/src/Docnet.Core/Editors/DocEditor.cs
@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using System.IO;
 using Docnet.Core.Bindings;
@@ -32,7 +31,7 @@ public byte[] Merge(byte[] fileOne, byte[] fileTwo)
             }
         }
 
-        public byte[] Merge(IList<byte[]> files)
+        public byte[] Merge(IReadOnlyList<byte[]> files)
         {
             lock (DocLib.Lock)
             {

diff --git a/src/Docnet.Core/Editors/IDocEditor.cs b/src/Docnet.Core/Editors/IDocEditor.cs
@@ -8,7 +8,7 @@ internal interface IDocEditor
 
         byte[] Merge(byte[] fileOne, byte[] fileTwo);
 
-        byte[] Merge(IList<byte[]> files);
+        byte[] Merge(IReadOnlyList<byte[]> files);
 
         byte[] Split(string filePath, int pageFromIndex, int pageToIndex);
 

diff --git a/src/Docnet.Core/IDocLib.cs b/src/Docnet.Core/IDocLib.cs
@@ -69,7 +69,7 @@ public interface IDocLib : IDisposable
         /// </summary>
         /// <param name="files">Files to merge to fileOne.</param>
         /// <returns>New file bytes.</returns>
-        byte[] Merge(IList<byte[]> files);
+        byte[] Merge(IReadOnlyList<byte[]> files);
 
         /// <summary>
         /// Split a range of pages into a separate document.

diff --git a/src/Docnet.Core/Validation/Validator.cs b/src/Docnet.Core/Validation/Validator.cs
@@ -5,7 +5,7 @@ namespace Docnet.Core.Validation
 {
     internal static class Validator
     {
-        public static void CheckCollectionNotEmpty<T>(ICollection<T> enumerable, string name)
+        public static void CheckCollectionNotEmpty<T>(IReadOnlyList<T> enumerable, string name)
         {
             if (enumerable.Count <= 0)
             {