general maintenance, pdfium version and some easy issue fixes

GowenGit · Apr 24, 2022 · 6842edb · 6842edb
1 parent 476cc6b
commit 6842edb
Show file tree

Hide file tree

Showing 14 changed files with 9 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@
 
 **docnet** aims to be a fast PDF editing and data extraction library. It is a `.NET Standard 2.0` wrapper for `PDFium C++` library that is used by `chromium`.
 
-PDFium version: `4955`
+PDFium version: `5010`
 
 Supported platforms:
 

diff --git a/src/Docnet.Core/Models/BoundBox.cs b/src/Docnet.Core/Models/BoundBox.cs
@@ -21,9 +21,6 @@ public BoundBox(int left, int top, int right, int bottom)
             Validator.CheckNotLessThanZero(right, nameof(right));
             Validator.CheckNotLessThanZero(bottom, nameof(bottom));
 
-            Validator.CheckOrder(left, right, nameof(left), nameof(right));
-            Validator.CheckOrder(top, bottom, nameof(top), nameof(bottom));
-
             Left = left;
             Top = top;
             Right = right;

diff --git a/src/Docnet.Core/Models/PageDimensions.cs b/src/Docnet.Core/Models/PageDimensions.cs
@@ -42,7 +42,7 @@ public PageDimensions(int dimOne, int dimTwo)
         /// scalingFactor represents a value to which physical page
         /// dimensions should scale in a pixel space.
         /// </summary>
-        /// <param name="scalingFactor">Page scaling PPI factor.</param>
+        /// <param name="scalingFactor">Page scaling factor in pixels-per-point. Convert PPI to scaling factor as PPI/72.</param>
         public PageDimensions(double scalingFactor)
         {
             Validator.CheckNotLessOrEqualToZero(scalingFactor, nameof(scalingFactor));

diff --git a/src/Docnet.Core/runtimes/linux-arm/native/pdfium.so b/src/Docnet.Core/runtimes/linux-arm/native/pdfium.so
diff --git a/src/Docnet.Core/runtimes/linux-arm64/native/pdfium.so b/src/Docnet.Core/runtimes/linux-arm64/native/pdfium.so
diff --git a/src/Docnet.Core/runtimes/linux/native/pdfium.so b/src/Docnet.Core/runtimes/linux/native/pdfium.so
diff --git a/src/Docnet.Core/runtimes/osx/native/pdfium.dylib b/src/Docnet.Core/runtimes/osx/native/pdfium.dylib
diff --git a/src/Docnet.Core/runtimes/win-x64/native/pdfium.dll b/src/Docnet.Core/runtimes/win-x64/native/pdfium.dll
diff --git a/src/Docnet.Core/runtimes/win-x86/native/pdfium.dll b/src/Docnet.Core/runtimes/win-x86/native/pdfium.dll
diff --git a/src/Docnet.Tests.Integration/Docs/sample_bound_box_order_01.pdf b/src/Docnet.Tests.Integration/Docs/sample_bound_box_order_01.pdf
diff --git a/src/Docnet.Tests.Integration/Docs/sample_form_fields_01.pdf b/src/Docnet.Tests.Integration/Docs/sample_form_fields_01.pdf
diff --git a/src/Docnet.Tests.Integration/PageReaderTests.cs b/src/Docnet.Tests.Integration/PageReaderTests.cs
@@ -203,6 +203,7 @@ public void GetText_WhenCalled_ShouldContainValidText(Input type, string filePat
         [InlineData(Input.FromBytes, "Docs/simple_2.pdf", null, 3, 10)]
         [InlineData(Input.FromBytes, "Docs/simple_5.pdf", null, 0, 40)]
         [InlineData(Input.FromBytes, "Docs/protected_0.pdf", "password", 0, 2009)]
+        [InlineData(Input.FromBytes, "Docs/sample_bound_box_order_01.pdf", null, 0, 5432)]
         public void GetCharacters_WhenCalled_ShouldReturnCharacters(Input type, string filePath, string password, int pageIndex, int charCount)
         {
             ExecuteForDocument(type, filePath, password, 10, 10, pageIndex, pageReader =>

diff --git a/src/Docnet.Tests.Unit/Models/BoundBoxTests.cs b/src/Docnet.Tests.Unit/Models/BoundBoxTests.cs
@@ -11,8 +11,6 @@ public class BoundBoxTests
         [InlineData(0, -1, 0, 0)]
         [InlineData(0, 0, -1, 0)]
         [InlineData(0, 0, 0, -1)]
-        [InlineData(5, 0, 2, 0)]
-        [InlineData(0, 5, 0, 2)]
         public void Ctor_WhenCalledWithInvalidVersion_ShouldThrow(int left, int top, int right, int bottom)
         {
             Assert.Throws<ArgumentException>(() => new BoundBox(left, top, right, bottom));

diff --git a/tools/get_pdfium.sh b/tools/get_pdfium.sh
@@ -1,11 +1,11 @@
 #!/bin/bash
 
-wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4955/pdfium-linux-x64.tgz
-wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4955/pdfium-linux-arm.tgz
-wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4955/pdfium-linux-arm64.tgz
-wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4955/pdfium-win-x64.tgz
-wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4955/pdfium-win-x86.tgz
-wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F4955/pdfium-mac-x64.tgz
+wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F5010/pdfium-linux-x64.tgz
+wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F5010/pdfium-linux-arm.tgz
+wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F5010/pdfium-linux-arm64.tgz
+wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F5010/pdfium-win-x64.tgz
+wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F5010/pdfium-win-x86.tgz
+wget https://github.com/bblanchon/pdfium-binaries/releases/download/chromium%2F5010/pdfium-mac-x64.tgz
 
 mkdir linux
 mkdir linux-arm