[gitbug] Correctly expand user home directory path #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, providing '~' as part of the path to a gitbug remote would not correctly expand to the user's home directory and error out with directory not found. This commit fixes the behavior to correctly expand the path instead, aligning behavior with that of the taskrc configuration option and other services' path expansion.
ryneeverett
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the git-bug service, providing '~' as part of the path to a gitbug remote would not correctly expand to the user's home directory and error out with directory not found.
This commit fixes the behavior to correctly expand the path instead, aligning it with that of the taskrc configuration option and other services' path expansion.
It simply switches out the
pathlib.Pathclass forconfig.ExpandedPath, which the gmail, gitlab and gerrit services also make use of.The PR includes a small test of the gitbug path configuration setup to avoid later regressions.
Hope this little PR is formatted well! Let me know if there's any remaining issues to be fixed.