Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove deprecated workflow for creating release. This would prevent accidental trigger of this workflow #9614

Merged

Conversation

Darien-Lin
Copy link
Contributor

Description
Currently, the release is controlled in another defined workflow. Spoke with @ericzzzzzzz and he confirmed that this workflow is no longer used and should be deleted.

@Darien-Lin Darien-Lin requested a review from a team as a code owner December 13, 2024 17:07
@Darien-Lin Darien-Lin requested a review from ChrisGe4 December 13, 2024 17:07
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed:

This pull request removes the deprecated draft-release.yml workflow from the Skaffold repository. The workflow was previously used for creating releases but has been superseded by a different workflow. The removal prevents accidental triggering of this outdated workflow, improving the CI/CD process and reducing potential confusion.

Specifically, the entire .github/workflows/draft-release.yml file has been deleted. This file contained a GitHub Actions workflow responsible for creating draft releases. The change is straightforward and addresses a clear need for cleanup and maintenance of the CI/CD pipeline.

Happy reviewing!

A tiny poem for your coding pleasure:

Old workflows sleep,
New systems rise, clean and bright,
Progress takes flight.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the deprecated draft-release.yml workflow. This is a good cleanup and prevents accidental triggers. The PR description clearly explains the reason for the change and references the discussion with @ericzzzzzzz, which is helpful for context. Since the entire file is being removed, there aren't specific line-by-line code suggestions to offer. However, I recommend updating any documentation or READMEs that might reference this workflow to reflect its removal. Additionally, ensure there are alternative mechanisms in place for creating releases, and that those are well-documented.

@Darien-Lin Darien-Lin requested a review from plumpy December 13, 2024 17:15
@Darien-Lin Darien-Lin merged commit 7b44ec3 into GoogleContainerTools:main Dec 13, 2024
23 checks passed
@Darien-Lin Darien-Lin deleted the removed-unused-workflow branch December 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants