Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tofu): Add support for deploying via OpenTofu #9591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abergmeier
Copy link

Description
Very simple initial config by introducing a new Deployment tofu. Simply uses an initialized Workspace to apply.

Since this needs an extension to 4beta11 schema introduces a new version 4beta12.

User facing changes
Has new tofu deploy struct with an obligatory workspace parameter.

Also introduces an integration test to ensure this works.

Very simple initial config by introducing a new Deployment `tofu`.
Simply uses an initialized Workspace to apply.

Since this needs an extension to 4beta11 schema introduces a new version
4beta12.
@abergmeier abergmeier changed the title Add support for OpenTofu feat(tofu): Add support for deploying via OpenTofu Nov 30, 2024
@oprudkyi
Copy link

oprudkyi commented Dec 1, 2024

@abergmeier thank you for effort,
I haven't checked deeply
but it seems pkg/skaffold/tofu/version_test.go expects version 0.16

			commands:        testutil.CmdRunOut("tofu version --json", `{"terraform_version": "0.16.0-alpha2"}`),
			expectedVersion: "0.16.0-alpha2",
		},

but there is already opentofu 1.8.6
https://github.com/opentofu/opentofu/releases

@abergmeier
Copy link
Author

@abergmeier thank you for effort, I haven't checked deeply but it seems pkg/skaffold/tofu/version_test.go expects version 0.16

			commands:        testutil.CmdRunOut("tofu version --json", `{"terraform_version": "0.16.0-alpha2"}`),
			expectedVersion: "0.16.0-alpha2",
		},

but there is already opentofu 1.8.6 https://github.com/opentofu/opentofu/releases

Is there any reason why you think testing for a particular version is necessary?
My reasoning was that the test should be fine with handling an "obscure" case.
The code so far does not really care about which tofu version is installed.

abergmeier referenced this pull request in hetznercloud/hcloud-cloud-controller-manager Dec 4, 2024
- Add a new development environment based on
[github.com/hetznercloud/kubernetes-dev-env](https://github.com/hetznercloud/kubernetes-dev-env)
- Refactor the Robot test server to be re-installed once a week and use
`overlayrootfs` for clean disk on every run

---------

Co-authored-by: Jonas Lammler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants