chore(cloudbuild): add configurable source bucket #9441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikanime
changed the title
shikanime
force-pushed
the
pr9441
branch
3 times, most recently
from
a20542b to
690be5d
Compare
|
@shikanime Thanks for your PR. Before we can review, can you fix the merge conflicts? Thanks! |
This pull request introduces a new configurable parameter for specifying a custom bucket. For example, the bucket name could follow the format `gs://[PROJECT_ID]_[builds/region]_cloudbuild`.
alphanota
approved these changes
Dec 20, 2024
alphanota
requested review from
alphanota
and removed request for
gsquared94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(cloudbuild): add configurable source bucket
This pull request introduces a new configurable parameter for specifying a custom bucket.
For example, the bucket name could follow the format
gs://[PROJECT_ID]_[builds/region]_cloudbuild.