Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add e2e test for HorizontalPodAutoscaler #615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented May 22, 2023

We get a bunch of support tickets involving HPA and metrics-service. This test uses both, which should help us ensure this use case works going forward.

Current related known issues:

  • metrics-service is a single replica, and when it fails or is rescheduled, API Discovery will error.
  • HPA updates its status relatively frequently, which can sometimes trigger the fight detector.

This test likely won't trigger either of those issues on kind, but might on GKE, especially autopilot. If the test is flakey tho, we'll have more motivation to fix them.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karlkfi karlkfi force-pushed the karl-hpa-e2e branch 4 times, most recently from d97292d to 0fa5216 Compare December 20, 2024 18:44
Copy link

google-oss-prow bot commented Dec 20, 2024

@karlkfi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit d101c00 link true /test kpt-config-sync-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant