Explicitly set the manifests' license header year #1400
Conversation
Camila-B
commented
Aug 22, 2024
Camila-B
commented
- This makes sure that the same year is always used when the license header for the manifests is generated, regardless of the current year
- Follow up to chore: bump manifest headers to 2024 #1092
- b/318417064
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -42,7 +42,7 @@ configsync-crds: "$(CONTROLLER_GEN)" "$(KUSTOMIZE)" "$(ADDLICENSE)" | |||
| && rm ./manifests/configmanagement.gke.io_namespaceconfigs.yaml \ | |||
| && rm ./manifests/configmanagement.gke.io_repoes.yaml \ | |||
| && rm ./manifests/configmanagement.gke.io_syncs.yaml \ | |||
| && "$(ADDLICENSE)" ./manifests | |||
| && "$(ADDLICENSE)" -y 2024 ./manifests | |||
There was a problem hiding this comment.
I don't think this really addresses the issue as described - this will just set all CRDs to always have a 2024 license.
- If a new CRD is added in 2025 (for example), it should use 2025 as the year
- I assume we also want previously created CRDs to match the year they were introduced
There was a problem hiding this comment.
Agreed. The add-license code always picks the latest year, which is correct for new files. The problem is that they're only marked as new because we're deleting and re-generating them.
We might need a more advanced solution that "fixes" the copyright year after generation if the file already existed beforehand, maybe by using a git diff --name-only --exit-code path/to/file in a bash script or something.
