-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update CONTRIBUTING guidelines (#4192)
* Update CONTRIBUTING.md
- Loading branch information
Showing
3 changed files
with
21 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,12 @@ | ||
Thank you for your interest in contributing! For general guidelines, please refer to | ||
the [contributing guide](https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md). | ||
|
||
Before filing a pull request, make sure to do the following: | ||
|
||
- [ ] Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose. | ||
- [ ] Ensure that your implementation plan is approved by the team. | ||
Please follow the guidelines below before opening an issue or a PR: | ||
- [ ] Ensure the issue was not already reported. | ||
- [ ] Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose if you are unable to find an existing issue addressing your problem. Make sure to include a title and clear description, as much relevant information as possible, and a code sample or an executable test case demonstrating the expected behavior that is not occurring. | ||
- [ ] Discuss the priority and potential solutions with the maintainers in the issue. The maintainers would review the issue and add a label "Accepting Contributions" once the issue is ready for accepting contributions. | ||
- [ ] Open a PR only if the issue is labeled with "Accepting Contributions", ensure the PR description clearly describes the problem and solution. Note that an open PR without an issues labeled with "Accepting Contributions" will not be accepted. | ||
- [ ] Verify that integration tests and unit tests are passing after the change. | ||
- [ ] Address all checkstyle issues. Refer to | ||
the [style guide](https://github.com/GoogleContainerTools/jib/blob/master/STYLE_GUIDE.md). | ||
|
||
This helps to reduce the chance of having a pull request rejected. | ||
- [ ] Address all checkstyle issues. Refer to the [style guide](https://github.com/GoogleContainerTools/jib/blob/master/STYLE_GUIDE.md). | ||
|
||
Fixes #<issue_number_goes_here> 🛠️ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters