Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #170: remove shared variables #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nitschSB
Copy link

@nitschSB nitschSB commented Jul 17, 2024

Hi,
I know the contributing guide says

Open a PR only if the issue is labeled with "Accepting Contributions"

I checked other PRs and think this is an outdated rule.

For me only the maven JibLayerFilterExtension is relevant. Maybe the other extensions contain the same bug.

Before submitting a pull request, please make sure to:

  • Identify an existing issue to associate
    with your proposed change, or file a new issue.
  • Describe any implementation plans in the issue and wait for a review from the repository maintainers.

Fixes #170 🛠️

Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant