Skip creating new image if env is empty #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker driver always creates a new container + image in
Setup
, which for large images causes a long delay duringDestroy
. For my image with a simple test that checks for the exit code, skipping the new image creation when there is no env saves 3min of execution time:Before:
container-structure-test -v debug test -c -i 0.03s user 0.03s system 0% cpu 3:26.83 total
After:
container-structure-test -v debug test -c -i 0.03s user 0.01s system 0% cpu 14.933 total