Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Create GitHub action.yml #401

Closed
wants to merge 2 commits into from
Closed

Conversation

MPV
Copy link
Contributor

@MPV MPV commented Oct 3, 2023

What

Add a proper action.yml file for GitHub Actions support, building on the previous work by @vsoch in:

As per docs:

Why

So it's possible to easily use this action in your workflows, like this:

[...]
steps:
  [...]
  - uses: GoogleContainerTools/container-diff@master

@google-cla
Copy link

google-cla bot commented Oct 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

action.yml Show resolved Hide resolved
@vsoch
Copy link
Contributor

vsoch commented Oct 4, 2023

Awesome!

@vsoch
Copy link
Contributor

vsoch commented Oct 4, 2023

@MPV I think it would be good to have (somewhere) example usage. E.g., typically actions have minimally a table with inputs and then a YAML file example, either in a README or a file that can be easily copy pasted. I'd also recommend adding a test for it.

@MPV
Copy link
Contributor Author

MPV commented Oct 5, 2023

@vsoch I don't disagree. Feel free to improve/iterate upon this as you see fit.

@vsoch
Copy link
Contributor

vsoch commented Oct 5, 2023

@MPV I won't have bandwidth any time soon but I can add to my TODO.

@vsoch
Copy link
Contributor

vsoch commented Oct 11, 2023

@MPV please see: #402 I'm including your commits there to give credit for your contribution, and opened a new PR mostly to skip the intermediate step of PR-ing to your PR to update here. Let me know what you think about my changes, and thanks for pinging me!

@MPV
Copy link
Contributor Author

MPV commented Oct 12, 2023

Closing in favor of #402

@MPV MPV closed this Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants