Unify hpl and intel-hpl via base_application #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with the following (checked both hpl and intel-hpl even though
only hpl is shown.) The only real difference is the addition of
`workload_group`.
```
$ ramble info -vvv hpl > new_dump.txt
$ git stash
$ ramble info -vvv hpl > old_dump.txt
$ diff old_dump.txt new_dump.txt
249a250,254
> ###################
> # workload_groups #
> ###################
> {'standard'}
> {'calculator'}
```
douglasjacobsen
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with the following (checked both hpl and intel-hpl even though only hpl is shown.) The only real difference is the addition of
workload_group.