Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppai/weather: add weather forecasting sample #8345

Merged

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented Sep 21, 2022

Description

This is an end-to-end sample to train a PyTorch model in Google Cloud. It uses Dataflow to create the datasets using Earth Engine data, then trains a PyTorch model in Vertex AI with GPUs, deploys the model to Cloud Run and gets predictions.

To run while staged:

!git clone -b ppai-weather-forecasting https://github.com/davidcavazos/python-docs-samples.git
%cd python-docs-samples/people-and-planet-ai/weather-forecasting

Checklist

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 21, 2022
@davidcavazos davidcavazos force-pushed the ppai-weather-forecasting branch from 27f4754 to d6be3f1 Compare October 10, 2022 21:41
@davidcavazos davidcavazos added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2022
@davidcavazos davidcavazos force-pushed the ppai-weather-forecasting branch from 373026f to 1135c25 Compare November 30, 2022 23:04
@davidcavazos davidcavazos marked this pull request as ready for review December 28, 2022 22:19
@davidcavazos davidcavazos requested a review from a team as a code owner December 28, 2022 22:19
@davidcavazos davidcavazos force-pushed the ppai-weather-forecasting branch from 908edb6 to f55503b Compare January 3, 2023 23:47
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple small nits such as do we need to update the header years to 2023 now that it is the new year?

@davidcavazos
Copy link
Contributor Author

I am working on adding Cloud Run predictions. The code itself remains pretty much the same, but I had to refactor the directory structures due to Python packaging and how Dataflow and Vertex AI expect files.

@davidcavazos davidcavazos force-pushed the ppai-weather-forecasting branch from 69c4515 to 6937f26 Compare January 9, 2023 21:01
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 18, 2023
@davidcavazos davidcavazos added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 18, 2023
@davidcavazos davidcavazos added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@davidcavazos davidcavazos added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@davidcavazos davidcavazos added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2023
@kweinmeister kweinmeister added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 18, 2023
@kweinmeister
Copy link
Contributor

FYI, I just set the "do not merge" label because that build check was stuck. Now it's green.

@dandhlee dandhlee merged commit 0bba5da into GoogleCloudPlatform:main Jan 18, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 18, 2023
@davidcavazos davidcavazos deleted the ppai-weather-forecasting branch January 18, 2023 22:50
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* ppai/weather-foreacasting: add weather sample

* remove temporary test model

* remove test scripts

* install local packages before testing

* update datasets

* add local packages to test requirements

* split notebook and tests

* add predictions notebook and tests

* add missing requirements

* update notebooks

* update test names

* fix tests

* enable vertex test

* copy file to directory

* update dependencies

* ignore checkpoints directory

* Simplify boolean test

Co-authored-by: Dan Lee <[email protected]>

* Improve wording

Co-authored-by: Dan Lee <[email protected]>

* Improve wording

Co-authored-by: Dan Lee <[email protected]>

* rename go to graph_objects

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Co-authored-by: Dan Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants