fix: Explicitly close connection after adding a connection #1381
+475
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to explicitly close client connections after adding a connection.
When connecting to an Impala cluster hosted in Docker we were getting an exception on variable clean up in SQL Alchemy. Closing clients before exiting prevented these exceptions.
I also took this opportunity to add some integration tests for Impala and raised a few new issues as a result of running them.
TODO: I don't know how to have the Impala tests run as part of a "gcbrun" test execution. I presume I don't have the necessary privileges to see it. We need to resolve this alongside the PR.