Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused k8s file #951

Closed
wants to merge 1 commit into from
Closed

Conversation

bourgeoisor
Copy link
Member

Fixes #557

cc: @shannonxtreme

@bourgeoisor bourgeoisor requested review from yoshi-approver and a team as code owners October 11, 2023 14:54
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean-up.

Should we also remove /gke-scheduled-autoscaler/k8s/hpa-example.yaml?

Also, I just noticed that the region tag for the following samples are identical:

@bourgeoisor
Copy link
Member Author

@NimJay no, hpa-example.yaml is used here: https://cloud.google.com/kubernetes-engine/docs/tutorials/reducing-costs-by-scaling-down-gke-off-hours#deploy_the_example_application

I also don't want to modify any region tags in this PR since it'd require changing the published tutorial source code as well.

Copy link
Collaborator

@NimJay NimJay Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! (You pointed out that gke-scheduled-autoscaler/k8s/hpa-example.yaml is in use.)

Issue: Also, it looks like this deployment-example.yaml is also used by that tutorial.

kubectl apply -f ./k8s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch. I had searched for the file name without realizing that command applied everything at once. Seems like we won't be able to simply remove it after all.

@bourgeoisor bourgeoisor deleted the issue-557-remove-unused-k8s-file branch October 13, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hpa-example from sample manifests
2 participants