Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples for LLM multi-host GPUs tutorials #1409

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

Edwinhr716
Copy link
Member

@Edwinhr716 Edwinhr716 commented Aug 15, 2024

Description

  • This pull-request adds samples for cl/663150039.

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • All dependencies are set to up-to-date versions, as applicable.

Copy link

snippet-bot bot commented Aug 15, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @Edwinhr716!
Looks good to me. :)

Question: Which cloud.google.com tutorial is this for?

Issue: Judging from the requirements outlined here, it sounds like you'll need a README.md for this folder.

@Edwinhr716
Copy link
Member Author

This is for a guide that is in the process of being released, it is a Multi-Host GPU tutorial using vllm. I'm preparing the files for the release.

As for the README.md, I can add it but I'm not sure if it is a hard requirement. I submitted this PR #1396 a couple of weeks ago without having to add one.

@NimJay NimJay changed the title added yaml file for multihost gpus user guide Add samples for LLM multi-host GPUs tutorials Aug 19, 2024
@NimJay
Copy link
Collaborator

NimJay commented Aug 19, 2024

Thanks for the quick response, @Edwinhr716! :)

Sounds good. Let's omit the README.md file — it's tedious work.
As a follow-up, I've created #1421 (ideally, README.md files would be automatically generated).

Ping me (@NimJay) when this is ready for merging.

@Edwinhr716
Copy link
Member Author

@NimJay it is ready for merging!

@NimJay NimJay merged commit 7d06c7f into GoogleCloudPlatform:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants