Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace golang.org/api/monitoring/v3 with cloud.google.com/go/monitoring/apiv3 #742

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

linxiulei
Copy link
Contributor

As google.golang.org/api/monitoring/v3 is deprecated with suboptimal performance and whatnot, it's recommended to use package cloud.google.com/go/monitoring/apiv3 instead.

An additional note: the most outstanding improvement in performance is that cloud.google.com/go/monitoring/apiv3 uses protobuf instead of json, which is used in google.golang.org/api/monitoring/v3. That decreases the resource overheads of data encodings when posting metric to cloud monitoring service.

@linxiulei
Copy link
Contributor Author

/cc @CatherineF-dev @leonzz

Copy link

@leonzz leonzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks @linxiulei!

@CatherineF-dev
Copy link
Contributor

LGTM. 2 small comments.

@CatherineF-dev CatherineF-dev merged commit 5a7e5a0 into GoogleCloudPlatform:master Jul 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants