prom-to-sd: Prefer proto in content type #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linxiulei
force-pushed
the
pb
branch
2 times, most recently
from
a998b5f to
8fcca67
Compare
|
cc @leonzz to have a review as well |
|
/lgtm |
leonzz
reviewed
Jul 16, 2024
| @@ -375,6 +377,11 @@ func convertToDistributionValue(h *dto.Histogram) *v3.Distribution { | |||
| prevVal = b.GetCumulativeCount() | |||
| } | |||
|
|
|||
| // +Inf Bucket is implicit so it needs to be added | |||
| if !infSeen && count > int64(prevVal) { | |||
There was a problem hiding this comment.
looks like this is addressing a different issue, could you add some background in the PR description?
There was a problem hiding this comment.
it's not a different issue because the +inf bucket is omitted in protobuf encoding but text encoding handles that specially (see https://github.com/prometheus/common/blob/main/expfmt/text_create.go#L232 if interested). However, it makes sense to separate the changes with description, for which I split the changes into 2 commits to make it clear.
Prometheus allows optional +Inf bucket and adds it in text encoding (see https://github.com/prometheus/common/blob/main/expfmt/text_create.go#L232). Google cloud monitoring requires +Inf explicitly if there are any data point in +Inf bucket. So we need to add +Inf bucket in conversion when needed.
Also add support for multiple response formats (text/proto)
leonzz
approved these changes
Jul 16, 2024
|
Will merge. Have discussed offline that the release flow will be expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add support for multiple response formats (text/proto)