Revert "Upgrade metrics adapter to v0.15.0-gke.0" #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm Discussed with Catherine, revert for now to mitigate bug but we need to roll forward some dependencies in a release as soon as possible. We should also investigate whether we can fix the issue with the discovery client. |
Try. From the bug description, it's highly related to the client-go version. |
leonzz
approved these changes
Jun 27, 2024
|
Just chatted about this again... My thoughts are actually that this is related to Helm's use of client-go, this adapter has been returning empty response forever. I believe that reverting this will not fix the issue as the old image version will still cause this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #712
client-go version was bumped in #690 to fix vulnerabilities. However, it might be related to #729.