Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readiness and liveness probe #710

Merged
merged 5 commits into from
May 6, 2024
Merged

Add readiness and liveness probe #710

merged 5 commits into from
May 6, 2024

Conversation

CatherineF-dev
Copy link
Contributor

@CatherineF-dev CatherineF-dev commented May 6, 2024 •
edited
Loading

Fixes: #485

Tested:

curl -k https://localhost:6443/livez
ok

curl -k https://localhost:6443/readyz
ok

k top pods -n custom-metrics
NAME                                                 CPU(cores)   MEMORY(bytes)   
custom-metrics-stackdriver-adapter-cddcdcf54-vdhlj   3m           32Mi

@CatherineF-dev
Copy link
Contributor Author

The failed test isn't related to this change.

The failed one is a flaky test, in checking

@CatherineF-dev
Copy link
Contributor Author

/retest

@CatherineF-dev
Copy link
Contributor Author

/retest

@CatherineF-dev CatherineF-dev merged commit 2001ba0 into GoogleCloudPlatform:master May 6, 2024
3 checks passed
This was referenced May 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonzz leonzz leonzz approved these changes

Assignees

@leonzz leonzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom stack driver pod doesnt seem to have liveness/readiness probe.
2 participants
@CatherineF-dev @leonzz