Skip to content

Commit

Permalink
Merge pull request #743 from bryan-hz/add-fake-external-metric
Browse files Browse the repository at this point in the history
Add a fake metric to the external metrics listing api
  • Loading branch information
CatherineF-dev authored Jul 18, 2024
2 parents 1324844 + c184af8 commit 23392aa
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,13 @@ func (p *StackdriverProvider) GetExternalMetric(ctx context.Context, namespace s
}

// ListAllExternalMetrics returns a list of available external metrics.
// Not implemented (currently returns empty list).
// Not implemented (currently returns a list of one fake metric).
func (p *StackdriverProvider) ListAllExternalMetrics() []provider.ExternalMetricInfo {
return []provider.ExternalMetricInfo{}
return []provider.ExternalMetricInfo{
{
Metric: "externalmetrics",
},
}
}

func min(a, b int) int {
Expand Down

0 comments on commit 23392aa

Please sign in to comment.