Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: swap satori's uuid package to gofrs #752

Merged
merged 4 commits into from
Feb 6, 2019

Conversation

mdanzinger
Copy link
Contributor

This updates the sample bookshelf app to use the community recommended gofrs uuid package.

go.uuid is effectively unmaintained and contained at least one critical security flaw which took half a year to be merged as the owner isn't active. See satori/go.uuid#75

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 6, 2019
@mdanzinger
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 6, 2019
@tbpg tbpg self-requested a review February 6, 2019 20:51
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would you mind updating appengine/gophers/gophers-6/main.go and appengine_flexible/analytics/analytics.go, too?

@broady
Copy link
Contributor

broady commented Feb 6, 2019

Thanks, great catch.

@mdanzinger
Copy link
Contributor Author

Thank you! Would you mind updating appengine/gophers/gophers-6/main.go and appengine_flexible/analytics/analytics.go, too?

Definitely! Not sure I missed them initially. Must have grepped inside of getting-started.

Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will wait for tests then merge.

@tbpg tbpg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@tbpg tbpg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@tbpg tbpg changed the title swap satori's uuid package to gofrs all: swap satori's uuid package to gofrs Feb 6, 2019
@tbpg tbpg merged commit d23bd6f into GoogleCloudPlatform:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants