Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional attempts for check_http_traffic, and update skip test message #178

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Additional attempts for check_http_traffic, and update skip test message #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,9 @@ check_http_status() {
eval_cmd="${eval_cmd} -k"
fi

# 60*5s=5min
# 180*5s=15min
local attempt
for attempt in $(seq 60); do
for attempt in $(seq 180); do
local got_code
got_code=$(eval ${eval_cmd} || true)
if [[ "${got_code}" == "${expect_code}" ]]; then
Expand Down
3 changes: 2 additions & 1 deletion test/recipe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ func runRecipeTest(t *testing.T, recipeDir string) {
for _, file := range []string{"setup.sh", "run-test.sh", "cleanup.sh"} {
path := path.Join(recipeDir, file)
if _, err := os.Stat(path); err != nil {
t.Skipf("Skipping test %q: stat(%q) = %v", recipeDir, path, err)
t.Logf("stat(%q) = %v", path, err)
t.Skipf("Skipping test %q: %q doesn't exist", recipeDir, path)
}
paths = append(paths, path)
}
Expand Down