Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal and external test #163

Merged

Conversation

sawsa307
Copy link
Contributor

  • Add genereate_config.sh to generate config for tests. It should be run before running tests.
  • Add tests for ingress internal and external.

@sawsa307 sawsa307 force-pushed the add-internal-and-external-test branch from e94bd69 to e94209c Compare October 11, 2023 21:41
@sawsa307 sawsa307 marked this pull request as draft October 14, 2023 09:20
@sawsa307 sawsa307 force-pushed the add-internal-and-external-test branch 3 times, most recently from 9b059b3 to 03f3084 Compare October 16, 2023 01:03
@sawsa307 sawsa307 marked this pull request as ready for review October 16, 2023 04:41
@sawsa307 sawsa307 force-pushed the add-internal-and-external-test branch from 03f3084 to 94e3003 Compare October 16, 2023 05:51
test/README.md Outdated
@@ -32,6 +32,18 @@ Make sure you are at the root directory of the repository.
cd gke-networking-recipes
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a section for set project instructions.

@sawsa307 sawsa307 force-pushed the add-internal-and-external-test branch 2 times, most recently from a21acf9 to a010e2b Compare October 23, 2023 20:21
@sawsa307 sawsa307 force-pushed the add-internal-and-external-test branch from a010e2b to 02a788f Compare October 26, 2023 04:30
* Add test scripts for ingress-internal and ingress-external.
@sawsa307 sawsa307 force-pushed the add-internal-and-external-test branch from 02a788f to a618aa1 Compare October 26, 2023 04:31
@bowei bowei merged commit 05a6c51 into GoogleCloudPlatform:main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants