-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log new configuration #2309
Log new configuration #2309
Conversation
cb0f397
to
5da619f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
+ Coverage 78.96% 79.10% +0.13%
==========================================
Files 106 105 -1
Lines 11606 11619 +13
==========================================
+ Hits 9165 9191 +26
+ Misses 1980 1969 -11
+ Partials 461 459 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c852d23
to
6547d49
Compare
b21695a
to
fc543fc
Compare
fc5a838
to
7a78b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
73fca46
to
702b7f9
Compare
b933a1f
to
fb2d373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from readability perspective.
I am not fully aware of the functional changes in the PR, so not commenting on that.
fb2d373
to
0238852
Compare
0238852
to
71dae5d
Compare
Description
Here is how the logs appear on Logs explorer:
JSON Format
Text Format
Link to the issue in case of a bug fix.
2239
Testing details