Refactored webhook validation logic.

GoogleCloudPlatform · Nov 9, 2023 · 3624972 · 3624972
1 parent bfad002
commit 3624972
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/webhook/mutatingwebhook.go b/pkg/webhook/mutatingwebhook.go
@@ -59,12 +59,12 @@ func (si *SidecarInjector) Handle(_ context.Context, req admission.Request) admi
 		return admission.Allowed(fmt.Sprintf("No injection required for operation %v.", req.Operation))
 	}
 
-	if v, ok := pod.Annotations[AnnotationGcsfuseVolumeEnableKey]; !ok || strings.ToLower(v) != "true" {
+	enableGcsfuseVolumes, ok := pod.Annotations[AnnotationGcsfuseVolumeEnableKey]
+	if !ok {
 		return admission.Allowed(fmt.Sprintf("The annotation key %q is not found, no injection required.", AnnotationGcsfuseVolumeEnableKey))
 	}
 
-	enableGcsfuseVolumes, ok := pod.Annotations[AnnotationGcsfuseVolumeEnableKey]
-	if !ok || strings.ToLower(enableGcsfuseVolumes) == "false" {
+	if strings.ToLower(enableGcsfuseVolumes) == "false" {
 		return admission.Allowed("No injection required.")
 	}