net: drop the weight argument from netif_napi_add

We tell driver developers to always pass NAPI_POLL_WEIGHT as the weight to netif_napi_add(). This may be confusing to newcomers, drop the weight argument, those who really need to tweak the weight can use netif_napi_add_weight(). Acked-by: Marc Kleine-Budde <[email protected]> # for CAN Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
GoogleCloudPlatform · Mar 23, 2023 · c559dab · c559dab
1 parent 5cfb516
commit c559dab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/google/gve/gve_main.c b/google/gve/gve_main.c
@@ -571,8 +571,7 @@ static void gve_add_napi(struct gve_priv *priv, int ntfy_idx,
 {
 	struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];
 
-	netif_napi_add(priv->dev, &block->napi, gve_poll,
-		       NAPI_POLL_WEIGHT);
+	netif_napi_add(priv->dev, &block->napi, gve_poll);
 }
 
 static void gve_remove_napi(struct gve_priv *priv, int ntfy_idx)

diff --git a/patches/netif_napi_add.cocci b/patches/netif_napi_add.cocci
@@ -2,7 +2,14 @@
 expression dev, napi, func, weight;
 @@
 
-netif_napi_add(dev, napi, func, weight);
++#if LINUX_VERSION_CODE >= KERNEL_VERSION(6,0,0)
+netif_napi_add(dev, napi, func);
++#else /* LINUX_VERSION_CODE >= KERNEL_VERSION(6,0,0) */
++netif_napi_add(dev, napi, func, NAPI_POLL_WEIGHT);
++#endif /* LINUX_VERSION_CODE >= KERNEL_VERSION(6,0,0) */
+
 +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,5,0) && LINUX_VERSION_CODE >= KERNEL_VERSION(3,11,0)
 +napi_hash_add(napi);
 +#endif /* LINUX_VERSION_CODE < KERNEL_VERSION(4,5,0) && LINUX_VERSION_CODE >= KERNEL_VERSION(3,11,0) */
+
+