Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty Array of Struct / Do not support null-valued Array of Struct #198

Closed

Conversation

MITSUBOSHI
Copy link

@MITSUBOSHI MITSUBOSHI commented Dec 5, 2024

Issues

Overview

As mentioned in the issue above, emulator behaves an opposite to the real world Spanner.

Before

SQL emulator Spanner(production)
SELECT IF(false, ARRAY<STRUCT<INT64>>[], null)
SELECT IF(false, ARRAY<STRUCT<INT64>>[], [])

After

SQL emulator Spanner(production)
SELECT IF(false, ARRAY<STRUCT<INT64>>[], null)
SELECT IF(false, ARRAY<STRUCT<INT64>>[], [])

…truct

according to the behaviour in realworld Spanner

fix: GoogleCloudPlatform#165
Copy link

google-cla bot commented Dec 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MITSUBOSHI
Copy link
Author

@olavloite @skuruppu
Hi, thank you for maintaining the emulator. Could you check and merge this PR :)?

@olavloite
Copy link
Contributor

@olavloite @skuruppu Hi, thank you for maintaining the emulator. Could you check and merge this PR :)?

Hi @MITSUBOSHI

Thanks for reaching out and reporting this issue. We can however not accept pull requests for this repository, because the code is not maintained on GitHub, but rather just exported here from a different (internal) repository.

@olavloite olavloite closed this Dec 5, 2024
@MITSUBOSHI
Copy link
Author

@olavloite
OK. Then, I submitted this issue to https://issuetracker.google.com/issues/382399965 .
I really hope this issue will be handled and resolved soon!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants