Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until video is ready before capture #8

Merged
merged 2 commits into from
Oct 28, 2017
Merged

Wait until video is ready before capture #8

merged 2 commits into from
Oct 28, 2017

Conversation

andsouto
Copy link
Contributor

With current code when the polyfill is in used the next code will fail because videoElement.videoWidth will still be 0:

let imageCapture = ImageCapture(track)
imageCapture.takePhoto();

The changes in this PR explicitly waits until the video element is ready waiting for the playing event before capturing the image. This way it works the same way as the native implementation where the previous code will work.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@andsouto
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dandv dandv merged commit 722b923 into GoogleChromeLabs:master Oct 28, 2017
@dandv
Copy link
Collaborator

dandv commented Oct 28, 2017

Thanks for the PR! Let's see if this fixes #4 for @RandomUsername07.

FluorescentHallucinogen added a commit to FluorescentHallucinogen/imagecapture-polyfill that referenced this pull request Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants