chore: refactor navigation #2881
Draft
+1,069
−382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/refactor-navigation-4
branch
from
8a96b32 to
3d6fdd6
Compare
sadym-chromium
force-pushed
the
sadym/refactor-navigation-4
branch
from
6b71d29 to
7f50236
Compare
sadym-chromium
changed the title
sadym-chromium
changed the title
OrKoN
reviewed
Dec 11, 2024
| } | ||
| } | ||
|
|
||
| /** | ||
| * Keeps track of navigations. Details: http://go/webdriver:bidi-navigation | ||
| */ | ||
| export class NavigationTracker { |
There was a problem hiding this comment.
could we cover major use cases with unit tests?
There was a problem hiding this comment.
added the major cases
|
There are a few new Puppeteer failures as well as far as I can see. |
sadym-chromium
force-pushed
the
sadym/refactor-navigation-4
branch
from
a60c5df to
ba31234
Compare
sadym-chromium
force-pushed
the
sadym/refactor-navigation-4
branch
from
ba31234 to
b506b68
Compare
OrKoN
reviewed
Dec 12, 2024
| }, { | ||
| 'method': 'browsingContext.navigationStarted', | ||
| 'params': { | ||
| 'context': 'stable_0', |
There was a problem hiding this comment.
the order seems wrong, why is the navigationStarted after domContentLoaded?
There was a problem hiding this comment.
read_sorted_messages sorts messages by methods alphabetically. We could introduce order-persisting helper method, but let's keep it out of scope of this PR
OrKoN
reviewed
Dec 12, 2024
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_aboutBlank_reload_checkEvents(websocket, context_id, html, |
There was a problem hiding this comment.
let's add tests for history updated and fragment navigations in before unload?
OrKoN
reviewed
Dec 12, 2024
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_aboutBlank_reload_checkEvents(websocket, context_id, html, |
There was a problem hiding this comment.
let's add tests that traverse history causes appropriate events?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Align navigation with the spec.
Navigation tracker relies on the following events:
Page.frameNavigatedNetwork.requestWillBeSent)Page.navigatedWithinDocumentPage.frameRequestedNavigationPage.javascriptDialogOpening:beforeunload