docs: use Module for BiDi as spec (#2861)

README.md

@@ -592,9 +592,9 @@ If your command has parameters, update the [`BidiCommandParameterParser`](https:
 
 Write the core logic for your command in the appropriate domain processor. Again, [example](https://github.com/GoogleChromeLabs/chromium-bidi/blob/0f971303281aba1910786035facc5eb54a833232/src/bidiMapper/modules/permissions/PermissionsProcessor.ts#L32) is your friend.
 
-#### Call the domain processor's method
+#### Call the module processor's method
 
-Call your new domain processor method from `CommandProcessor.#processCommand`, passing in the parsed parameters. [Example](https://github.com/GoogleChromeLabs/chromium-bidi/blob/0f971303281aba1910786035facc5eb54a833232/src/bidiMapper/CommandProcessor.ts#L313).
+Call your new module processor method from `CommandProcessor.#processCommand`, passing in the parsed parameters. [Example](https://github.com/GoogleChromeLabs/chromium-bidi/blob/0f971303281aba1910786035facc5eb54a833232/src/bidiMapper/CommandProcessor.ts#L313).
 
 #### Add e2e tests
 

src/bidiMapper/BidiNoOpParser.ts

@@ -31,7 +31,7 @@ import type {
 import type {BidiCommandParameterParser} from './BidiParser.js';
 
 export class BidiNoOpParser implements BidiCommandParameterParser {
-  // Bluetooth domain
+  // Bluetooth module
   // keep-sorted start block=yes
   parseHandleRequestDevicePromptParams(
     params: unknown,
@@ -55,7 +55,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Browser domain
+  // Browser module
   // keep-sorted start block=yes
   parseRemoveUserContextParams(
     params: unknown,
@@ -64,7 +64,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Browsing Context domain
+  // Browsing Context module
   // keep-sorted start block=yes
   parseActivateParams(params: unknown): BrowsingContext.ActivateParameters {
     return params as BrowsingContext.ActivateParameters;
@@ -114,7 +114,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // CDP domain
+  // CDP module
   // keep-sorted start block=yes
   parseGetSessionParams(params: unknown): Cdp.GetSessionParameters {
     return params as Cdp.GetSessionParameters;
@@ -127,7 +127,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Script domain
+  // Script module
   // keep-sorted start block=yes
   parseAddPreloadScriptParams(
     params: unknown,
@@ -153,7 +153,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Input domain
+  // Input module
   // keep-sorted start block=yes
   parsePerformActionsParams(params: unknown): Input.PerformActionsParameters {
     return params as Input.PerformActionsParameters;
@@ -166,7 +166,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Network domain
+  // Network module
   // keep-sorted start block=yes
   parseAddInterceptParams(params: unknown): Network.AddInterceptParameters {
     return params as Network.AddInterceptParameters;
@@ -204,7 +204,7 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Permissions domain
+  // Permissions module
   // keep-sorted start block=yes
   parseSetPermissionsParams(
     params: unknown,
@@ -213,14 +213,14 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Session domain
+  // Session module
   // keep-sorted start block=yes
   parseSubscribeParams(params: unknown): Session.SubscriptionRequest {
     return params as Session.SubscriptionRequest;
   }
   // keep-sorted end
 
-  // Storage domain
+  // Storage module
   // keep-sorted start block=yes
   parseDeleteCookiesParams(params: unknown): Storage.DeleteCookiesParameters {
     return params as Storage.DeleteCookiesParameters;

src/bidiMapper/BidiParser.ts

@@ -29,7 +29,7 @@ import type {
 } from '../protocol/protocol.js';
 
 export interface BidiCommandParameterParser {
-  // Bluetooth domain
+  // Bluetooth module
   // keep-sorted start block=yes
   parseHandleRequestDevicePromptParams(
     params: unknown,
@@ -45,14 +45,14 @@ export interface BidiCommandParameterParser {
   ): Bluetooth.SimulatePreconnectedPeripheralParameters;
   // keep-sorted end
 
-  // Browser domain
+  // Browser module
   // keep-sorted start block=yes
   parseRemoveUserContextParams(
     params: unknown,
   ): Browser.RemoveUserContextParameters;
   // keep-sorted end
 
-  // Browsing Context domain
+  // Browsing Context module
   // keep-sorted start block=yes
   parseActivateParams(params: unknown): BrowsingContext.ActivateParameters;
   parseCaptureScreenshotParams(
@@ -78,28 +78,28 @@ export interface BidiCommandParameterParser {
   ): BrowsingContext.TraverseHistoryParameters;
   // keep-sorted end
 
-  // CDP domain
+  // CDP module
   // keep-sorted start block=yes
   parseGetSessionParams(params: unknown): Cdp.GetSessionParameters;
   parseResolveRealmParams(params: unknown): Cdp.ResolveRealmParameters;
   parseSendCommandParams(params: unknown): Cdp.SendCommandParameters;
   // keep-sorted end
 
-  // Input domain
+  // Input module
   // keep-sorted start block=yes
   parsePerformActionsParams(params: unknown): Input.PerformActionsParameters;
   parseReleaseActionsParams(params: unknown): Input.ReleaseActionsParameters;
   parseSetFilesParams(params: unknown): Input.SetFilesParameters;
   // keep-sorted end
 
-  // PermissionsDomain domain
+  // Permissions module
   // keep-sorted start block=yes
   parseSetPermissionsParams(
     params: unknown,
   ): Permissions.SetPermissionParameters;
   // keep-sorted end block=yes
 
-  // Network domain
+  // Network module
   // keep-sorted start block=yes
   parseAddInterceptParams(params: unknown): Network.AddInterceptParameters;
   parseContinueRequestParams(
@@ -121,7 +121,7 @@ export interface BidiCommandParameterParser {
   parseSetCacheBehavior(params: unknown): Network.SetCacheBehaviorParameters;
   // keep-sorted end block=yes
 
-  // Script domain
+  // Script module
   // keep-sorted start block=yes
   parseAddPreloadScriptParams(
     params: unknown,
@@ -135,12 +135,12 @@ export interface BidiCommandParameterParser {
   ): Script.RemovePreloadScriptParameters;
   // keep-sorted end
 
-  // Session domain
+  // Session module
   // keep-sorted start block=yes
   parseSubscribeParams(params: unknown): Session.SubscriptionRequest;
   // keep-sorted end
 
-  // Storage domain
+  // Storage module
   // keep-sorted start block=yes
   parseDeleteCookiesParams(params: unknown): Storage.DeleteCookiesParameters;
   parseGetCookiesParams(params: unknown): Storage.GetCookiesParameters;

src/bidiMapper/modules/network/NetworkProcessor.ts

@@ -27,7 +27,7 @@ import type {NetworkRequest} from './NetworkRequest.js';
 import type {NetworkStorage} from './NetworkStorage.js';
 import {isSpecialScheme, type ParsedUrlPattern} from './NetworkUtils.js';
 
-/** Dispatches Network domain commands. */
+/** Dispatches Network module commands. */
 export class NetworkProcessor {
   readonly #browsingContextStorage: BrowsingContextStorage;
   readonly #networkStorage: NetworkStorage;

src/bidiMapper/modules/network/NetworkUtils.ts

@@ -17,7 +17,7 @@
  */
 
 /**
- * @fileoverview Utility functions for the Network domain.
+ * @fileoverview Utility functions for the Network module.
  */
 import type {Protocol} from 'devtools-protocol';
 

src/bidiMapper/modules/session/EventManager.ts

@@ -196,7 +196,7 @@ export class EventManager extends EventEmitter<EventManagerEventsMap> {
     }
 
     // List of the subscription items that were actually added. Each contains a specific
-    // event and context. No domain event (like "network") or global context subscription
+    // event and context. No module event (like "network") or global context subscription
     // (like null) are included.
     const addedSubscriptionItems: SubscriptionItem[] = [];
 
@@ -225,7 +225,7 @@ export class EventManager extends EventEmitter<EventManagerEventsMap> {
     }
 
     // Iterate over all new subscription items and call hooks if any. There can be
-    // duplicates, e.g. when subscribing to the whole domain and some specific event in
+    // duplicates, e.g. when subscribing to the whole module and some specific event in
     // the same time ("network", "network.responseCompleted"). `distinctValues` guarantees
     // that hooks are called only once per pair event + context.
     distinctValues(addedSubscriptionItems).forEach(({contextId, event}) => {

src/bidiMapper/modules/session/SubscriptionManager.spec.ts

@@ -308,7 +308,7 @@ describe('SubscriptionManager', () => {
       ).to.deep.equal([]);
     });
 
-    it('should unsubscribe the domain', () => {
+    it('should unsubscribe the module', () => {
       subscriptionManager.subscribe(ALL_EVENTS, SOME_CONTEXT, SOME_CHANNEL);
       subscriptionManager.unsubscribe(ALL_EVENTS, SOME_CONTEXT, SOME_CHANNEL);
       expect(
@@ -319,7 +319,7 @@ describe('SubscriptionManager', () => {
       ).to.deep.equal([]);
     });
 
-    it('should not unsubscribe the domain if not subscribed', () => {
+    it('should not unsubscribe the module if not subscribed', () => {
       subscriptionManager.subscribe(ALL_EVENTS, SOME_CONTEXT, SOME_CHANNEL);
       subscriptionManager.unsubscribe(ALL_EVENTS, SOME_CONTEXT, SOME_CHANNEL);
       expect(

src/bidiMapper/modules/storage/StorageProcessor.ts

@@ -32,7 +32,7 @@ import {
 } from '../network/NetworkUtils.js';
 
 /**
- * Responsible for handling the `storage` domain.
+ * Responsible for handling the `storage` module.
  */
 export class StorageProcessor {
   readonly #browserCdpClient: CdpClient;

src/bidiTab/BidiParser.ts

@@ -30,7 +30,7 @@ import type {
 import * as Parser from '../protocol-parser/protocol-parser.js';
 
 export class BidiParser implements BidiCommandParameterParser {
-  // Bluetooth domain
+  // Bluetooth module
   // keep-sorted start block=yes
   parseHandleRequestDevicePromptParams(
     params: unknown,
@@ -54,7 +54,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Browser domain
+  // Browser module
   // keep-sorted start block=yes
   parseRemoveUserContextParams(
     params: unknown,
@@ -63,7 +63,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Browsing Context domain
+  // Browsing Context module
   // keep-sorted start block=yes
   parseActivateParams(params: unknown): BrowsingContext.ActivateParameters {
     return Parser.BrowsingContext.parseActivateParams(params);
@@ -113,7 +113,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // CDP domain
+  // CDP module
   // keep-sorted start block=yes
   parseGetSessionParams(params: unknown): Cdp.GetSessionParameters {
     return Parser.Cdp.parseGetSessionRequest(params);
@@ -126,7 +126,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Input domain
+  // Input module
   // keep-sorted start block=yes
   parsePerformActionsParams(params: unknown): Input.PerformActionsParameters {
     return Parser.Input.parsePerformActionsParams(params);
@@ -139,7 +139,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Network domain
+  // Network module
   // keep-sorted start block=yes
   parseAddInterceptParams(params: unknown): Network.AddInterceptParameters {
     return Parser.Network.parseAddInterceptParameters(params);
@@ -177,7 +177,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Permissions domain
+  // Permissions module
   // keep-sorted start block=yes
   parseSetPermissionsParams(
     params: unknown,
@@ -186,7 +186,7 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Script domain
+  // Script module
   // keep-sorted start block=yes
   parseAddPreloadScriptParams(
     params: unknown,
@@ -212,14 +212,14 @@ export class BidiParser implements BidiCommandParameterParser {
   }
   // keep-sorted end
 
-  // Session domain
+  // Session module
   // keep-sorted start block=yes
   parseSubscribeParams(params: unknown): Session.SubscriptionRequest {
     return Parser.Session.parseSubscribeParams(params);
   }
   // keep-sorted end
 
-  // Storage domain
+  // Storage module
   // keep-sorted start block=yes
   parseDeleteCookiesParams(params: unknown): Storage.DeleteCookiesParameters {
     return Parser.Storage.parseDeleteCookiesParams(params);