Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract creation API #27

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Contract creation API #27

merged 6 commits into from
Oct 5, 2023

Conversation

Blackmorse
Copy link
Contributor

@Blackmorse
Copy link
Contributor Author

@GoodforGod , Are you still maintaining the repo ?

@GoodforGod
Copy link
Owner

Hello @Blackmorse

Of course, I'll check your PR during this week, thanks for it!

@GoodforGod GoodforGod self-assigned this Sep 27, 2023
@GoodforGod GoodforGod added the enhancement New feature or request label Sep 27, 2023
@GoodforGod GoodforGod changed the base branch from master to dev September 27, 2023 12:21
@GoodforGod
Copy link
Owner

@Blackmorse add please this .filter(s -> !BasicUtils.isBlank(s)) to here for tests to run, looks like an empty ENV is passed

@Blackmorse
Copy link
Contributor Author

@GoodforGod , check please If I got you right

@GoodforGod
Copy link
Owner

Code style 🥲

@Blackmorse
Copy link
Contributor Author

@GoodforGod
Code style has been fixed..

@GoodforGod GoodforGod merged commit 3b1af9d into GoodforGod:dev Oct 5, 2023
0 of 2 checks passed
@GoodforGod GoodforGod mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodforGod GoodforGod GoodforGod approved these changes

Assignees

@GoodforGod GoodforGod

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blackmorse @GoodforGod