test: 스크랩 관련 Domain, Service 유닛 테스트 코드 작성 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumzen
changed the title
…erver into test/post-pagination
dl-00-e8
reviewed
May 23, 2024
There was a problem hiding this comment.
이런 식으로 쿼리로 리팩토링하신 것 좋은 방법인 것 같습니다!
There was a problem hiding this comment.
Spring Security가 있어서 통합 테스트하려면 Security 테스트 환경을 구축해야 합니다! 제가 아직 안 해놔서.. 꼭 시간 나면 해놓을게요
There was a problem hiding this comment.
별도의 Builder 패턴을 사용하지 않고 이렇게 생성자를 만드신 이유 궁금합니다!
There was a problem hiding this comment.
Builder 패턴 사용했을 때 id값이 자동으로 설정이 안되어서 수동으로 id값을 설정해주기 위해 사용했습니다 이 부분에 대해서는 한번 다시 찾아보고 수정해보겠습니다!!
There was a problem hiding this comment.
비슷한 메소드들끼리 @nested 활용해서 묶어주신 것 굉장히 좋은 방법인 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)