Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ Refactor/DetailAndApplyPageStyleUnit#313 [κ³΅κ³ μƒμ„ΈνŽ˜μ΄μ§€ 및 μ§€μ›μ„œ μž‘μ„± μŠ€νƒ€μΌ λ‹¨μœ„ rem 톡일] #314

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

sseuldev
Copy link
Collaborator

@sseuldev sseuldev commented Nov 11, 2024

PR ν…œν”Œλ¦Ώ

체크리슀트!

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”?
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?
  • πŸ’­ μ΄μŠˆλŠ” λ“±λ‘ν–ˆλ‚˜μš”?
  • 🏷️ 라벨은 λ“±λ‘ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μ—­

  1. 곡고 μƒμ„ΈνŽ˜μ΄μ§€ 및 μ§€μ›μ„œ μž‘μ„± νŽ˜μ΄μ§€ 전체 μŠ€νƒ€μΌ λ‹¨μœ„ px μ—μ„œ rem 으둜 μˆ˜μ • μ™„λ£Œ
  2. 곡고 μƒμ„ΈνŽ˜μ΄μ§€ 메인 타이틀 λ””μžμΈ μˆ˜μ • 반영 μ™„λ£Œ (타이틀 μ–‘ μ˜† 이미지 제거)
  3. index.html 파일 μˆ˜μ •
  4. 전체적인 곡고 μƒμ„ΈνŽ˜μ΄μ§€ λ””μžμΈ 크기 μ‘°μ •

ν”Όλ“œλ°±μ„ λ°›κ³  싢은 λΆ€λΆ„

곡고 μƒμ„ΈνŽ˜μ΄μ§€ 및 μ§€μ›μ„œ μž‘μ„± λΆ€λΆ„μ˜ μŠ€νƒ€μΌμ΄ 깨지지 μ•ŠλŠ”μ§€ 확인 λΆ€νƒλ“œλ €μš”!

image

PR 특이 사항

특이 사항 :

Issue Number: #313

close: #313

#313 κ³΅κ³ μƒμ„ΈνŽ˜μ΄μ§€ 및 μ§€μ›μ„œ μž‘μ„± μŠ€νƒ€μΌ λ‹¨μœ„ rem 톡일
@sseuldev sseuldev added the β™»οΈλ¦¬νŒ©ν† λ§ λ¦¬νŒ©ν† λ§ 쀑 label Nov 11, 2024
@sseuldev sseuldev self-assigned this Nov 11, 2024
@sseuldev sseuldev added the πŸ™†πŸ»β€β™€οΈ κ΅¬ν˜„ μ™„λ£Œ Improvements or additions to documentation label Nov 11, 2024
#313 곡고 μƒμ„ΈνŽ˜μ΄μ§€ 타이틀 λ””μžμΈ 및 index.html μˆ˜μ •
Copy link
Contributor

@Herrypi Herrypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ ν™”λ©΄ κΉ¨μ§€μ§€μ•Šκ³  잘 λ³΄μž…λ‹ˆλ‹€!

@sseuldev sseuldev merged commit 4ab338f into develop Nov 12, 2024
@sseuldev sseuldev deleted the Refactor/DetailAndApplyPageStyleUnit#313 branch November 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
β™»οΈλ¦¬νŒ©ν† λ§ λ¦¬νŒ©ν† λ§ 쀑 πŸ™†πŸ»β€β™€οΈ κ΅¬ν˜„ μ™„λ£Œ Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants