Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https were applicable #493

Closed
wants to merge 51 commits into from
Closed

Conversation

salartarium
Copy link
Contributor

Changed a few links to use https for speed and security

GoldenGnu added 30 commits May 23, 2024 22:57
Merge main
Merge main
@GoldenGnu
Copy link
Owner

Thank you! 👍

Please add yourself as contributor in the following places:
https://github.com/GoldenGnu/jeveassets/blob/main/src/main/java/net/nikr/eve/jeveasset/gui/dialogs/AboutDialog.java#L100
https://github.com/GoldenGnu/jeveassets/blob/main/credits.txt#L28
You can use your real name, an alias/eve name, or a combination of both.

You can either update this PR, make a new PR, or you can let me know what name you want added and I can do it for you.

@salartarium
Copy link
Contributor Author

I believe I have successfully updated the PR ;)

@GoldenGnu
Copy link
Owner

Sorry, you merged the develop branch into the main branch, which we only do on release of the develop branch:
Merge branch 'develop' into main
That means I can't merge this PR, all your changes are good, except for that.

@GoldenGnu GoldenGnu closed this Oct 16, 2024
@GoldenGnu GoldenGnu reopened this Oct 18, 2024
@GoldenGnu
Copy link
Owner

GoldenGnu commented Oct 18, 2024

I'm going to see if I can somehow fix this

@GoldenGnu
Copy link
Owner

Manually merged in 863b745

Thank you very much for your contribution! 🎉👍 Sorry for the complications!

@GoldenGnu GoldenGnu closed this Oct 18, 2024
@GoldenGnu
Copy link
Owner

Released in 7.9.1

@salartarium
Copy link
Contributor Author

Saw this was merged on the forums! Sorry, for not responding. Kind of losing interest in the game. Thanks for dealing with my lack of IT skills. 😅

@GoldenGnu
Copy link
Owner

No worries! I'm happy it all worked out in the end. If you're on the jEveAssets discord or join at any point, be sure to PM me so I can give you the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants