Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifies Sepolia deployment -> uses the newer official hardhat-verify package #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adds a custom chain for sepolia etherscan api

Signed-off-by: Stefan Adolf <[email protected]>
@elmariachi111
Copy link
Author

@Asper9

@elmariachi111 elmariachi111 changed the title uses the newer official hardhat-verify package verifies Sepolia deplyoment -> uses the newer official hardhat-verify package Jul 31, 2023
@elmariachi111 elmariachi111 changed the title verifies Sepolia deplyoment -> uses the newer official hardhat-verify package verifies Sepolia deployment -> uses the newer official hardhat-verify package Aug 1, 2023
Copy link

@oalkuisnet oalkuisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address the concerns please

@@ -1,4 +1,4 @@
import "@nomiclabs/hardhat-etherscan";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this change is needed as I can't see anywhere where hardhat-verify is used in the repository. Can you shed more light why this is needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, https://github.com/NomicFoundation/hardhat/tree/main/packages/hardhat-etherscan

The @nomiclabs/hardhat-etherscan plugin is deprecated in favor of our new @nomicfoundation/hardhat-verify plugin.
hardhat-verify is a drop-in replacement of hardhat-etherscan.

it's used on the hardhat config. Can't exactly remember why I upgraded it in the first place, but the currently used plugin didn't support sepolia for sure.

@@ -216,5 +216,15 @@ export default {
},
etherscan: {
apiKey: MY_ETHERSCAN_API_KEY,
customChains: [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why sepolia is not added to networks list?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already on it, somewhere around L 117. The only missing piece was verification support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants