-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verifies Sepolia deployment -> uses the newer official hardhat-verify package #4
base: main
Are you sure you want to change the base?
verifies Sepolia deployment -> uses the newer official hardhat-verify package #4
Conversation
adds a custom chain for sepolia etherscan api Signed-off-by: Stefan Adolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you address the concerns please
@@ -1,4 +1,4 @@ | |||
import "@nomiclabs/hardhat-etherscan"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this change is needed as I can't see anywhere where hardhat-verify is used in the repository. Can you shed more light why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, https://github.com/NomicFoundation/hardhat/tree/main/packages/hardhat-etherscan
The @nomiclabs/hardhat-etherscan plugin is deprecated in favor of our new @nomicfoundation/hardhat-verify plugin.
hardhat-verify is a drop-in replacement of hardhat-etherscan.
it's used on the hardhat config. Can't exactly remember why I upgraded it in the first place, but the currently used plugin didn't support sepolia for sure.
@@ -216,5 +216,15 @@ export default { | |||
}, | |||
etherscan: { | |||
apiKey: MY_ETHERSCAN_API_KEY, | |||
customChains: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why sepolia is not added to networks list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's already on it, somewhere around L 117. The only missing piece was verification support.
adds a custom chain for sepolia etherscan api
see https://github.com/NomicFoundation/hardhat/tree/main/packages/hardhat-verify
verified the sepolia deployments
https://sepolia.etherscan.io/address/0x231F3Fd7c3E3C9a2c8A03B72132c31241DF0a26C#code
https://sepolia.etherscan.io/address/0xDDeFBcF94d46E771dad74882012704f51CA15ed8#code
https://sepolia.etherscan.io/address/0xE0AD16EB7Ea467C694E6cFdd5E7D61FE850e8B53#code