Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z2m filter created devices #1907

Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Oct 3, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fixes #1890 and #1655

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...services/zigbee2mqtt/api/zigbee2mqtt.controller.js 100.00% <100.00%> (ø)
...r/services/zigbee2mqtt/lib/getDiscoveredDevices.js 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@atrovato atrovato force-pushed the z2m-filter-created-devices branch from e7f0be6 to a4bee6d Compare October 4, 2023 09:54
@atrovato atrovato marked this pull request as ready for review October 4, 2023 10:16
@relativeci
Copy link

relativeci bot commented Oct 4, 2023

Job #1928: Bundle Size — 8.82MiB (+0.02%).

bd6b640(current) vs f87a192 master#1925(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #1928
     Baseline
Job #1925
Regression  Initial JS 4.77MiB(+0.04%) 4.77MiB
No change  Initial CSS 301.31KiB 301.31KiB
No change  Cache Invalidation 53.91% 53.91%
No change  Chunks 48 48
No change  Assets 152 152
No change  Modules 1377 1377
No change  Duplicate Modules 19 19
No change  Duplicate Code 0.69% 0.69%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1928
     Baseline
Job #1925
Regression  JS 6.39MiB (+0.03%) 6.39MiB
Not changed  IMG 2MiB 2MiB
Not changed  CSS 316.97KiB 316.97KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 15.48KiB 15.48KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #1928 reportView atrovato:z2m-filter-created-devi... branch activity

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a small feedback

server/services/zigbee2mqtt/lib/getDiscoveredDevices.js Outdated Show resolved Hide resolved
@atrovato atrovato force-pushed the z2m-filter-created-devices branch from a4bee6d to bd6b640 Compare October 17, 2023 04:42
@atrovato
Copy link
Contributor Author

I made the requested change, I will do the same for LANManger later on another PR.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now!

@Pierre-Gilles Pierre-Gilles merged commit bb5a6a6 into GladysAssistant:master Oct 27, 2023
9 checks passed
@atrovato atrovato deleted the z2m-filter-created-devices branch October 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zigbee2mqtt] Hide already added devices
2 participants