Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene: In device.set-value action, binary feature should default to 0 #1901

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix #1892

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80befd2
Status: ✅  Deploy successful!
Preview URL: https://c7e5ccb8.gladys-plus.pages.dev
Branch Preview URL: https://fix-toggle-bug-scene.gladys-plus.pages.dev

View logs

@relativeci
Copy link

relativeci bot commented Sep 28, 2023

Job #1867: Bundle Size — 8.82MiB (~+0.01%).

80befd2(current) vs 1d56a4e master#1865(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1867
     Baseline
Job #1865
Initial JS 4.77MiB(~+0.01%) 4.76MiB
Initial CSS 301.31KiB 301.31KiB
Cache Invalidation 53.9% 58.35%
Chunks 48 48
Assets 152 152
Modules 1376 1376
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1867
     Baseline
Job #1865
CSS 316.97KiB 316.97KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 2MiB 2MiB
JS 6.39MiB (~+0.01%) 6.39MiB
Media 0B 0B
Other 15.48KiB 15.48KiB

View job #1867 reportView fix-toggle-bug-scene branch activity

@Pierre-Gilles Pierre-Gilles merged commit 3334ae3 into master Sep 28, 2023
@Pierre-Gilles Pierre-Gilles deleted the fix-toggle-bug-scene branch September 28, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCENE] Control a device OFF position is not initialized by default
1 participant