Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full screen bug + add full screen GET parameter #1883

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 18, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Add a ?fullscreen=force GET parameter to the dashboard for wall tablets

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: acbb2f8
Status: ✅  Deploy successful!
Preview URL: https://d486de70.gladys-plus.pages.dev
Branch Preview URL: https://full-screen-dashboard.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified lines are covered by tests ✅

see 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@relativeci
Copy link

relativeci bot commented Sep 18, 2023

Job #1862: Bundle Size — 8.7MiB (+0.01%).

acbb2f8(current) vs e223e3f master#1860(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1862
     Baseline
Job #1860
Initial JS 4.72MiB 4.72MiB
Initial CSS 301.15KiB 301.15KiB
Cache Invalidation 63.83% 54.2%
Chunks 48 48
Assets 151 151
Modules 1363(+0.07%) 1362
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1862
     Baseline
Job #1860
CSS 316.81KiB 316.81KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.35MiB (+0.02%) 6.34MiB
Media 0B 0B
Other 15.4KiB 15.4KiB

View job #1862 reportView full-screen-dashboard branch activity

@Pierre-Gilles Pierre-Gilles merged commit 3760147 into master Sep 28, 2023
@Pierre-Gilles Pierre-Gilles deleted the full-screen-dashboard branch September 28, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant