Fix #2000 : Should not delete tags when patching scene without tags (#…

…2055)
GladysAssistant · Apr 19, 2024 · 2251726 · 2251726
1 parent 1154325
commit 2251726
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/server/lib/scene/scene.update.js b/server/lib/scene/scene.update.js
@@ -34,13 +34,12 @@ async function update(selector, scene) {
 
   await existingScene.update(scene);
 
-  await db.TagScene.destroy({
-    where: {
-      scene_id: existingScene.id,
-    },
-  });
-
   if (scene.tags) {
+    await db.TagScene.destroy({
+      where: {
+        scene_id: existingScene.id,
+      },
+    });
     await db.TagScene.bulkCreate(
       scene.tags.map((tag) => ({
         scene_id: existingScene.id,

diff --git a/server/test/lib/scene/scene.update.test.js b/server/test/lib/scene/scene.update.test.js
@@ -34,6 +34,17 @@ describe('scene.update', () => {
     assertSinon.calledOnce(brain.addNamedEntity);
     assertSinon.calledOnce(brain.removeNamedEntity);
   });
+  it('should not delete tags when patching scene', async () => {
+    const scene = await sceneManager.update('test-scene', {
+      name: 'Name updated',
+      tags: [{ name: 'tag 1' }],
+    });
+    expect(scene.tags).deep.eq([{ name: 'tag 1' }]);
+    const scene2 = await sceneManager.update('test-scene', {
+      name: 'Name updated 2',
+    });
+    expect(scene2.tags).deep.eq([{ name: 'tag 1' }]);
+  });
   it('should return not found', async () => {
     const promise = sceneManager.update('not-found-scene', {
       name: 'Updated scene',