Skip to content

Commit

Permalink
DuckDB: Properly close all connections & database on shutdown (#2151)
Browse files Browse the repository at this point in the history
  • Loading branch information
Pierre-Gilles authored Oct 31, 2024
1 parent d46ba5b commit 01e7779
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
18 changes: 15 additions & 3 deletions server/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,25 @@ const closeSQLite = async () => {
}
};

// Close properly all DuckDB connections & database
const closeDuckDB = async () => {
try {
await db.duckDb.close();
logger.info('DuckDB closed.');
return new Promise((resolve) => {
db.duckDbReadConnection.close((err1) => {
db.duckDbWriteConnection.close((err2) => {
db.duckDb.close((err3) => {
if (err1 || err2 || err3) {
logger.error(err1, err2, err3);
}
logger.info('DuckDB closed.');
resolve();
});
});
});
});
} catch (e) {
logger.info('DuckDB database is probably already closed');
logger.warn(e);
return null;
}
};

Expand Down
2 changes: 2 additions & 0 deletions server/models/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ const db = {
sequelize,
umzug,
duckDb,
duckDbWriteConnection,
duckDbReadConnection,
duckDbWriteConnectionAllAsync,
duckDbReadConnectionAllAsync,
duckDbCreateTableIfNotExist,
Expand Down

0 comments on commit 01e7779

Please sign in to comment.