-
Notifications
You must be signed in to change notification settings - Fork 385
FBSnapshotTestCase integration. Initial tests for AttributedStringView #688
FBSnapshotTestCase integration. Initial tests for AttributedStringView #688
Conversation
If we don’t add the snapshots to git, we can only test this locally... is that what we want? Sent with GitHawk |
@BasThomas actual snapshots are in repo. But we won't store failure diffs, since they should be picked up by CI and/or PR author for investigation :) |
@BasThomas for example we have this in PR (and this should always be part of repo, ofc it doesn't make sense to store reference images locally only), |
Ah, obviously. Nevermind me 😔 |
@BasThomas no worries :) |
Thing is - we use them at work too. Just wasn't thinking. 😅 |
@rnystrom hi! I see some conflicts already, should i update PR or we're going to merge this later? |
Hi, @rnystrom |
Hey! Sorry this fell off my radar. Yes! Let's rebase and I'll land. |
f058d8c
to
47ae42a
Compare
@rnystrom Thanks for response! Rebased and ready to go |
Haven't seen the source for this tweet, but sounds like FBSnapshotTestCase might not be maintained any more? |
We use this at Instagram, it's a wonderful tool for building UI w/out having to spin up the entire app. Not to mention regression testing. |
This PR adds (#656):