Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types - remove unused bottle_data interface #424

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Types - remove unused bottle_data interface #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8304d1
remove bottle_data type from IGif
giannif Nov 29, 2023
f479d02
changeset
giannif Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-panthers-warn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@giphy/js-types': major
---

remove unused bottle_data interface from IGif. This should only affect internal GIPHY projects
6 changes: 0 additions & 6 deletions packages/types/src/gif.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ import { IImages } from './images'
import IUser from './user'
import IVideo from './video'

interface IBottleData {
tid?: string
tags?: string[]
}

export type GifID = string | number

export default interface IGif {
Expand Down Expand Up @@ -34,7 +29,6 @@ export default interface IGif {
is_scheduled: boolean
is_removed: boolean
tags: string[]
bottle_data: IBottleData
analytics_response_payload: string
video?: IVideo
emoji_group_id?: number
Expand Down