remove getAsTag as thats obsolete with the new usernames. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2023 09:39
|
Is the username rollout finished though? What happens in this case if the user still has a tag? |
|
Yeah you'll want a misc util method for |
|
Discord will be automatically changing tags to usernames on March 4th from what i've heard, we could wait until then? |
Yes, once that's done we can remove tag support. I think bots may still have tags but not too important |
|
Usernames are now fully migrated, we could move ahead with this PR 👀 |
onebeastchris
approved these changes
May 23, 2024
Chew
reviewed
May 23, 2024
| @@ -164,7 +164,7 @@ public void onGuildMemberJoin(@NotNull GuildMemberJoinEvent event) { | |||
| try { | |||
| ServerSettings.getLogChannel(event.getGuild()).sendMessageEmbeds(new EmbedBuilder() | |||
| .setAuthor("Member Joined", null, event.getUser().getAvatarUrl()) | |||
| .setDescription(event.getUser().getAsMention() + " " + event.getUser().getAsTag()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.